Christian Hergert [Thu, 5 Nov 2020 00:58:50 +0000 (16:58 -0800)]
macos: remove synthesize_motion helper
We can use gdk_surface_request_motion() now instead of our extra
helper to do essentially the same thing.
Christian Hergert [Wed, 4 Nov 2020 22:40:11 +0000 (14:40 -0800)]
macos: always create dummy window/view for GL context
This simplifies the creation by always creating the dummy views, and then
removes it if necessary by detecting the begin_frame/end_frame pair.
Christian Hergert [Thu, 5 Nov 2020 00:28:13 +0000 (16:28 -0800)]
Revert "Simplify gdk_surface_queue_render"
This reverts commit
2120e9df880cabfe21d5a4e8c2d0e6804a4e09d8.
Matthias Clasen [Wed, 4 Nov 2020 20:41:09 +0000 (20:41 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Matthiasc/for master
See merge request GNOME/gtk!2779
Matthias Clasen [Wed, 4 Nov 2020 20:37:39 +0000 (20:37 +0000)]
Merge branch 'ebassi/for-master' into 'master'
Ebassi/for master
See merge request GNOME/gtk!2778
Matthias Clasen [Wed, 4 Nov 2020 19:56:52 +0000 (14:56 -0500)]
popovermenu: Fail gracefully if no model
If we don't have a model yet, return FALSE from
gtk_popover_menu_add_custom().
Matthias Clasen [Tue, 3 Nov 2020 20:47:03 +0000 (15:47 -0500)]
Cosmetics
Extraneous pair of parens snuck in with
2120e9df88.
Matthias Clasen [Tue, 3 Nov 2020 20:28:40 +0000 (15:28 -0500)]
surface: Be smarter about autohide
When we close grabbing popups due to an outside
click, check at each level if the click is still
outside. This makes closing the nested popover
menu in the popover on page 3 of widget-factory
work as expected, when you click the menubutton
again.
Matthias Clasen [Tue, 3 Nov 2020 20:26:47 +0000 (15:26 -0500)]
surface: Be more lenient for autohide
When an event happens on a non-grabbing popup that hangs off
a grabbing popup, don't trigger the autohide. This makes touch
text handles work inside the popover on page 3 of widget-factory.
Emmanuele Bassi [Wed, 4 Nov 2020 19:39:08 +0000 (19:39 +0000)]
a11y: Remove stray g_printerr()
Emmanuele Bassi [Wed, 4 Nov 2020 19:38:14 +0000 (19:38 +0000)]
a11y: Hide the "indent" in GtkTreeExpander
It's just padding.
Emmanuele Bassi [Wed, 4 Nov 2020 18:59:11 +0000 (18:59 +0000)]
a11y: Describe window controls
The window controls for client side decorations have only icons, which
means they are not accessible.
Matthias Clasen [Wed, 4 Nov 2020 18:10:55 +0000 (18:10 +0000)]
Merge branch 'a11y/atcontext-realize' into 'master'
A11y/atcontext realize
See merge request GNOME/gtk!2772
Matthias Clasen [Wed, 4 Nov 2020 17:54:48 +0000 (12:54 -0500)]
gtk-demo: Simplify the run button
Don't create the label manually. It is not necessary,
and letting the button do it also improves the
accessibility setup.
Matthias Clasen [Wed, 4 Nov 2020 17:53:23 +0000 (12:53 -0500)]
gtk-demo: Set some accessible properties
Set labels in the builder demo. The ARIA authoring practices
say that both menubars and toolbars *must* have an accessible
label.
Emmanuele Bassi [Wed, 4 Nov 2020 16:59:19 +0000 (16:59 +0000)]
a11y: Move parent context ref getter to its own function
Keeps the body of handle_accessible_get_property() readable.
Emmanuele Bassi [Wed, 4 Nov 2020 16:43:59 +0000 (16:43 +0000)]
a11y: Make the Button labelled by its child label
Establish the relation whenever we set the label widget.
Emmanuele Bassi [Wed, 4 Nov 2020 16:42:16 +0000 (16:42 +0000)]
a11y: Use the tooltip text as the accessible description
It's more common to have a tooltip as the accessible description than an
explicit description. This is also the behaviour of GTK3.
Emmanuele Bassi [Wed, 4 Nov 2020 16:41:31 +0000 (16:41 +0000)]
Set accessible label on GTK Demo's primary menu
Otherwise its label is going to be "GtkMenuButton".
Emmanuele Bassi [Wed, 4 Nov 2020 16:40:59 +0000 (16:40 +0000)]
a11y: Unrealize ATContext on dispose
Matthias Clasen [Wed, 4 Nov 2020 16:53:07 +0000 (11:53 -0500)]
Propagate accessible-role to backend
We want to allow setting the accessible role as long
as the context is unrealized, so we need to propagate
the new role.
Matthias Clasen [Wed, 4 Nov 2020 16:36:52 +0000 (11:36 -0500)]
gtk-demo: Set an accessible role
Set an accessible role for the toolbar in the
builder demo. This tests accessibility support
in GtkBuilder.
Emmanuele Bassi [Wed, 4 Nov 2020 14:35:16 +0000 (14:35 +0000)]
a11y: Allow updating role on unrealized contexts
We can still change the accessible role if an ATContext instance is
unrealized.
Emmanuele Bassi [Mon, 19 Oct 2020 16:44:50 +0000 (17:44 +0100)]
a11y: Move ATContext to an explicit realization model
We are doing too much work during the construction phase of the
AT-SPI backend for GtkATContext. Instead of having the AtSpiContext
register itself at construction time, let's add explicit realize
and unrealize operations, and connect the ATContext realization to the
rooting operation of a GtkWidget.
kai-berlin [Sat, 31 Oct 2020 22:21:04 +0000 (22:21 +0000)]
broadway: Set modifier state of scroll events
Set modifier state of scroll events, so Ctrl-scroll
works.
Fixes: #2733
Matthias Clasen [Tue, 3 Nov 2020 20:15:08 +0000 (20:15 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Matthiasc/for master
Closes #3318, #3319, and #3320
See merge request GNOME/gtk!2776
Matthias Clasen [Tue, 3 Nov 2020 19:39:29 +0000 (14:39 -0500)]
texthandle: Queue a draw when role changes
This helps with role changes not taking immediate
effect.
Fixes: #3320
Matthias Clasen [Tue, 3 Nov 2020 19:37:27 +0000 (14:37 -0500)]
Simplify gdk_surface_queue_render
We can just call gdk_surface_invalidate_rect here
like we do elsewhere in gdk, and I'm a bit uncertain
about the current code that adds an empty update
region.
Matthias Clasen [Tue, 3 Nov 2020 17:37:07 +0000 (12:37 -0500)]
texthandle: Fix positioning
Use the same approach we use for popovers, using
gtk_widget_get_surface_allocation. It works.
Fixes: #3319
Matthias Clasen [Tue, 3 Nov 2020 17:09:43 +0000 (12:09 -0500)]
widget-factory: Make sure we close popover on page 3
We don't want the popover to stay open when we open
an about dialog or shortcuts window. Since cascade-popdown
would also affect e.g. the context menu of the text widgets,
do this explicitly.
Matthias Clasen [Tue, 3 Nov 2020 15:23:34 +0000 (10:23 -0500)]
popover: Change default for cascade-popdown
We've found a number of cases where this cascading
has unexpected side-effects. So, turn it off by
default, and only set it for menus.
Matthias Clasen [Tue, 3 Nov 2020 15:12:32 +0000 (10:12 -0500)]
Adwaita: Set a background for magnifiers
The magnifier in entries is magnifying the GtkText
widget, which does not draw any background itself.
Therefore, we give the magnifier a background, to
make things look as expected.
Fixes: #3318
Matthias Clasen [Tue, 3 Nov 2020 15:11:50 +0000 (10:11 -0500)]
magnifier: Set a css name
Predictably, we use the name "magnifier".
Matthias Clasen [Tue, 3 Nov 2020 14:41:33 +0000 (09:41 -0500)]
NEWS: Updates
Matthias Clasen [Tue, 3 Nov 2020 12:33:31 +0000 (07:33 -0500)]
docs: Mention g_file_get_basename
Mention g_file_get_basename in the migration guide section
about GtkFileChooser api changes.
Matthias Clasen [Tue, 3 Nov 2020 12:14:21 +0000 (12:14 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Matthiasc/for master
See merge request GNOME/gtk!2774
Matthias Clasen [Tue, 3 Nov 2020 03:50:03 +0000 (22:50 -0500)]
gtk-demo: Remove more gtk3-demo icon uses
Use our own logo everywhere.
Matthias Clasen [Tue, 3 Nov 2020 03:43:44 +0000 (22:43 -0500)]
gtk-demo: Tweak images demo
Use our own logo instead of the gtk3-demo one, and
tweak the headings to refledct what we show.
Matthias Clasen [Tue, 3 Nov 2020 01:58:28 +0000 (20:58 -0500)]
gtk-demo: Reanimate floppy buddy
Implement a GdkPaintable wrapper around GdkPixbufAnimation,
so floppy buddy can waive again.
Matthias Clasen [Tue, 3 Nov 2020 00:15:26 +0000 (19:15 -0500)]
widget-factory: Restore modality of the about dialog
Make the about dialog of widget-factory modal again.
This was lost in
87a8fda163d419ee3e.
Timm Bäder [Sun, 1 Nov 2020 11:27:59 +0000 (12:27 +0100)]
gl renderer: Make debugging code shorter
Timm Bäder [Sun, 1 Nov 2020 11:22:06 +0000 (12:22 +0100)]
gl renderer: Refactor vertex data loading code
Timm Bäder [Sun, 1 Nov 2020 11:16:44 +0000 (12:16 +0100)]
gl renderer: Use the load_vertex_data* functions more often
Timm Bäder [Sun, 1 Nov 2020 10:25:00 +0000 (11:25 +0100)]
gl renderer: More load_vertex_data* usage
Timm Bäder [Sat, 31 Oct 2020 16:15:24 +0000 (17:15 +0100)]
gl renderer: Reword a comment
Timm Bäder [Sat, 31 Oct 2020 16:13:31 +0000 (17:13 +0100)]
gl renderer: Remove an outdated comment
Timm Bäder [Sat, 31 Oct 2020 16:12:38 +0000 (17:12 +0100)]
gl renderer: Refactor rendering shadow nodes
Also use load_vertex_data_with_region here.
Timm Bäder [Sat, 31 Oct 2020 10:54:33 +0000 (11:54 +0100)]
gl renderer: Refactor blurred shadow drawing code
We already have various load_vertex_data* code, so try to reuse that
here.
Timm Bäder [Sat, 31 Oct 2020 07:54:27 +0000 (08:54 +0100)]
gl renderer: Nine-slice unblurred outset shadows
See #3284
Timm Bäder [Fri, 23 Oct 2020 09:01:34 +0000 (11:01 +0200)]
printoperation: Remove double assignment
Matthias Clasen [Mon, 2 Nov 2020 19:36:09 +0000 (19:36 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
gtk-demo polish
See merge request GNOME/gtk!2773
Matthias Clasen [Mon, 2 Nov 2020 18:56:19 +0000 (13:56 -0500)]
gtk-demo: Renovate the paned demo
Make this look less like testgtk from GTK 2.
Matthias Clasen [Mon, 2 Nov 2020 17:02:19 +0000 (12:02 -0500)]
fixup: window titles
Matthias Clasen [Mon, 2 Nov 2020 17:01:11 +0000 (12:01 -0500)]
gtk-demo: Polish all entry demos
Make the spacing a bit more consistent, and tweak
some strings here and there.
Matthias Clasen [Mon, 2 Nov 2020 17:00:24 +0000 (12:00 -0500)]
gtk-demo: Polish the search bar demo
Rename this, and make it look a bit less like a
debugging tool, and more like a demo.
Matthias Clasen [Mon, 2 Nov 2020 16:59:22 +0000 (11:59 -0500)]
gtk-demo: Tweak tagged entry styling
Move the tags closer together, and avoid resizing too much.
Matthias Clasen [Mon, 2 Nov 2020 16:05:57 +0000 (11:05 -0500)]
gtk-demo: Tweak window titles
This is an attempt to improve consistency in the sidebar
and the window titles.
Matthias Clasen [Mon, 2 Nov 2020 13:38:20 +0000 (08:38 -0500)]
gtk-demo: Use typographic style classes
We don't need to hardcode <u> in markup anymore.
Use the heading style class instead.
Matthias Clasen [Mon, 2 Nov 2020 11:52:13 +0000 (11:52 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Matthiasc/for master
See merge request GNOME/gtk!2769
Matthias Clasen [Sun, 1 Nov 2020 19:47:02 +0000 (14:47 -0500)]
testsuite: Add tests for gtk4-builder-tool validate
Matthias Clasen [Mon, 2 Nov 2020 01:39:43 +0000 (20:39 -0500)]
builder-tool: Stop rewriting GtkPopoverMenu
We no longer allow manual creation of GtkPopoverMenu,
translating individual properties is not going to
change that.
Matthias Clasen [Sun, 1 Nov 2020 22:32:47 +0000 (17:32 -0500)]
testsuite: Test GtkFixed rewriting
Matthias Clasen [Sun, 1 Nov 2020 21:51:14 +0000 (16:51 -0500)]
builder-tool: Rewrite GtkFixed more
GtkFixedLayout does not have layout properties
for x and y, so turn those into a transform.
Matthias Clasen [Sun, 1 Nov 2020 19:47:42 +0000 (14:47 -0500)]
builder-tool: Avoid duplicate path prefixes
It is enough to print the file in which the error
occurred once; GtkBuilder already makes that part
of its error message.
Matthias Clasen [Sun, 1 Nov 2020 20:48:37 +0000 (15:48 -0500)]
builder-tool: Install a log writer
Install a log writer function that is a bit simpler than
the default GLib log writer, and does not put PIDs and
timestamps in the output, so we can compare easily in
our testsuite.
Matthias Clasen [Sun, 1 Nov 2020 20:47:44 +0000 (15:47 -0500)]
Set G_LOG_USE_STRUCTURED globally
It doesn't make much sense to set this in per-directory
meson files, since that makes use use different logging
facilities in different parts of the project. Set it
globally.
Matthias Clasen [Sun, 1 Nov 2020 15:37:58 +0000 (10:37 -0500)]
testsuite: Test GtkToolbar rewriting
Matthias Clasen [Sun, 1 Nov 2020 19:13:49 +0000 (14:13 -0500)]
builder-tool: Rewrite GtkToolbar more
Replace GtkToolbar with GtkBox and GtkToolButton with
GtkButton.
Matthias Clasen [Sun, 1 Nov 2020 16:39:28 +0000 (11:39 -0500)]
testsuite: Test GtkActionBar rewriting
Matthias Clasen [Sun, 1 Nov 2020 16:38:49 +0000 (11:38 -0500)]
testsuite: Test GtkPaned rewriting
Matthias Clasen [Sun, 1 Nov 2020 16:37:16 +0000 (11:37 -0500)]
builder-tool: Fix rewriting GtkPaned
The properties have been renamed in
bc6643f3c22a61c.
Matthias Clasen [Sun, 1 Nov 2020 16:14:24 +0000 (11:14 -0500)]
builder-tool: Drop unneeded code
We are rewriting the tree before simplifying it,
so there is no need to 'keep things for rewriting'
in the simplify phase.
Matthias Clasen [Sun, 1 Nov 2020 16:12:50 +0000 (11:12 -0500)]
testsuite: Test GtkOverlay rewriting
Matthias Clasen [Sun, 1 Nov 2020 16:14:03 +0000 (11:14 -0500)]
buildertool: Improve GtkOverlay rewriting
Translate the GtkOverlay:pass-through child property to
the GtkWidget:measure property, and drop the :index
child property.
Matthias Clasen [Sun, 1 Nov 2020 16:27:22 +0000 (11:27 -0500)]
Fix the definition of GtkWidget:can-target
We are setting the value to TRUE initially, but
the property had a declared default of FALSE.
This is messing up the simplification of .ui files
with gtk4-builder-tool, since it thinks it can
omit can-target properties when it really can't.
Matthias Clasen [Sun, 1 Nov 2020 16:15:08 +0000 (11:15 -0500)]
Cosmetics
Matthias Clasen [Sun, 1 Nov 2020 15:50:53 +0000 (10:50 -0500)]
Remove leftover file
This was never used in tests.
Matthias Clasen [Sun, 1 Nov 2020 15:48:29 +0000 (10:48 -0500)]
testsuite: More gtk4-builder-tool tests
Matthias Clasen [Sun, 1 Nov 2020 15:33:53 +0000 (10:33 -0500)]
testsuite: Test gtk4-builder-tool simplify --replace
Run all gtk4-builder-tool test with and without --replace.
This improves test coverage for gtk4-builder-tool
Matthias Clasen [Sun, 1 Nov 2020 15:32:13 +0000 (10:32 -0500)]
builder-tool: Avoid a crash
Be more careful about types that have been removed.
I was getting criticals when converting ui files
containing GtkToolbars.
Matthias Clasen [Sun, 1 Nov 2020 00:51:23 +0000 (20:51 -0400)]
testsuite: Improve coverage for GdkTexture
Matthias Clasen [Sat, 31 Oct 2020 19:15:19 +0000 (15:15 -0400)]
testsuite: Improve coverage for GdkDisplayManager
Matthias Clasen [Sat, 31 Oct 2020 18:57:43 +0000 (14:57 -0400)]
testsuite: Improve coverage for seats
Matthias Clasen [Sat, 31 Oct 2020 18:57:28 +0000 (14:57 -0400)]
testsuite: Improve coverage for rectangles
Tim Sabsch [Sun, 1 Nov 2020 14:08:13 +0000 (14:08 +0000)]
Update German translation
Piotr Drąg [Sun, 1 Nov 2020 09:37:21 +0000 (10:37 +0100)]
Update Polish translation
Matthias Clasen [Sat, 31 Oct 2020 18:57:02 +0000 (14:57 -0400)]
testsuite: Improve coverage for keys
Matthias Clasen [Sat, 31 Oct 2020 05:03:14 +0000 (01:03 -0400)]
testsuite: Add more css parser tests
Add tests for url parsing.
Matthias Clasen [Sat, 31 Oct 2020 12:27:52 +0000 (08:27 -0400)]
testsuite: Add a forgotten test
I've written this test a while ago, but did not add
it to the test data list in meson.build.
Matthias Clasen [Sat, 31 Oct 2020 04:36:47 +0000 (00:36 -0400)]
testsuite: Add a css test
This test verifies that CDO and CDC are ignored
as required.
Matthias Clasen [Sat, 31 Oct 2020 04:37:39 +0000 (00:37 -0400)]
css: Fix tokenization of CDO
A CDO is 4 characters: <!--, not 3 as our tokenizer
was pretending.
Matthias Clasen [Sat, 31 Oct 2020 03:34:48 +0000 (23:34 -0400)]
gsk: Don't compile unused code
The NodeSample and GskGLImage code is not used,
so don't compile it.
Matthias Clasen [Sat, 31 Oct 2020 03:33:34 +0000 (23:33 -0400)]
testsuite: Improve coverage for GtkMultiSorter
Matthias Clasen [Sat, 31 Oct 2020 03:33:15 +0000 (23:33 -0400)]
testsuite: Improve coverage for GtkStringList
Matthias Clasen [Sat, 31 Oct 2020 03:32:30 +0000 (23:32 -0400)]
Remove an unused function
The only property of GtkStringObject is readonly since
commit
fb14f50ec1a8fe9b9024e, so we don't need a
set_property implementation.
Matthias Clasen [Sat, 31 Oct 2020 03:04:23 +0000 (23:04 -0400)]
testsuite: Improve coverage
Matthias Clasen [Sat, 31 Oct 2020 02:51:54 +0000 (22:51 -0400)]
Drop an unused private function
Matthias Clasen [Sat, 31 Oct 2020 02:50:38 +0000 (22:50 -0400)]
Drop unused includes
Matthias Clasen [Sat, 31 Oct 2020 01:34:23 +0000 (21:34 -0400)]
testsuite: Improve coverage for GtkExpression
Matthias Clasen [Sat, 31 Oct 2020 02:24:53 +0000 (22:24 -0400)]
expression: Fix property expressions for interfaces
We were not checking the passed-in type in the right
way. An interface type can still pass the
g_type_is_a (..., G_TYPE_OBJECT) check, if G_TYPE_OBJECT
is one of its prerequisites. What we need to check is
whether the fundamental type is G_TYPE_OBJECT.